dmenu but for gay people who enjoy some dickage
Go to file
NRK 41fdabbf7c drw_text: improve both performance and correctness
this patch makes some non-trivial changes, which significantly improves
the performance of drawing large strings as well as fixes any issues
regarding the printing of the ellipsis when string gets truncated.

* performance:

before there were two O(n) loops, one which finds how long we can go
without changing font, and the second loop would (incorrectly) truncate
the string if it's too big.

this patch merges the overflow calculation into the first loop and exits
out when overflow is detected. when dumping lots of emojies into dmenu,
i see some noticeable startup time improvement:

before -> after
460ms  -> 360ms

input latency when scrolling up/down is also noticeably better and can
be tested with the following:

	for _ in $(seq 20); do
		cat /dev/urandom | base64 | tr -d '\n' | head -c 1000000
	echo
	done | ./dmenu -l 10

* correctness:

the previous version would incorrectly assumed single byte chars and
would overwrite them with '.' , this caused a whole bunch of obvious
problems, including the ellipsis not getting rendered if then font
changed.

in addition to exiting out when we detect overflow, this patch also
keeps track of the last x-position where the ellipsis would fit. if we
detect overflow, we simply make a recursing call to drw_text() at the
ellipsis_x position and overwrite what was there.

so now the ellipsis will always be printed properly, regardless of
weather the font changes or if the string is single byte char or not.

the idea of rendering the ellipsis on top incase of overflow was
from Bakkeby <bakkeby@gmail.com>, thanks! however the original patch had
some issues incorrectly truncating the prompt (-p flag) and cutting off
emojies. those have been fixed in here.
2022-03-25 22:49:07 +01:00
arg.h arg.h: fixed argv checks order 2016-02-23 00:31:03 +01:00
config.def.h config.def.h: style improvement, use color Scheme enum 2016-06-28 17:56:25 +02:00
config.mk bump version to 5.1 2022-02-11 12:26:35 +01:00
dmenu_path make dmenu_path script executable 2019-02-12 22:13:58 +01:00
dmenu_run dmenu_run: Split cache logic to dmenu_path again 2012-07-30 17:02:12 +02:00
dmenu.1 dmenu.1: document improved fastgrab behaviour from previous patch 2019-01-27 15:28:02 +01:00
dmenu.c remove false-positive warning for int comparison as bool 2022-03-01 22:45:39 +01:00
drw.c drw_text: improve both performance and correctness 2022-03-25 22:49:07 +01:00
drw.h import new drw from libsl and minor fixes. 2016-06-03 19:13:15 +02:00
LICENSE bump version to 5.1 2022-02-11 12:26:35 +01:00
Makefile Makefile: just show the compiler output 2018-06-02 17:09:01 +02:00
README removed libdc dependence 2010-11-11 23:56:39 +00:00
stest.1 applied Martin Kühl's inverse matching flag to stest 2013-08-13 19:15:04 +02:00
stest.c remove always true condition in if statement 2021-07-25 10:55:45 +02:00
util.c die() on calloc failure 2016-11-05 11:36:42 +01:00
util.h import new drw from libsl and minor fixes. 2016-06-03 19:13:15 +02:00

dmenu - dynamic menu
====================
dmenu is an efficient dynamic menu for X.


Requirements
------------
In order to build dmenu you need the Xlib header files.


Installation
------------
Edit config.mk to match your local setup (dmenu is installed into
the /usr/local namespace by default).

Afterwards enter the following command to build and install dmenu
(if necessary as root):

    make clean install


Running dmenu
-------------
See the man page for details.